From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: xenbus_backend_client.c / xenbus_client.c merger
Date: Mon, 19 Feb 2007 17:48:15 +0000
Message-ID: <C1FF935F.9B51%keir@xensource.com>
References: <1171904850.4099.91.camel@moonstone.uk.level5networks.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1171904850.4099.91.camel@moonstone.uk.level5networks.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Kieran Mansley <kmansley@solarflare.com>, Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 19/2/07 17:07, "Kieran Mansley" <kmansley@solarflare.com> wrote:

> Accepting one grant reference is not a big deal - I can just get a grant
> per page and pass all the grants, then allocate a two page vm_area map
> the individual grants at the appropriate offsets into that area to get
> them virtually contiguous.

Then it doesn't seem that a new helper function is very useful! You'll just
end up with alloc_vm_area() followed by open coding of requesting mapping of
two grant references, won't you? A general function that did all that would
be reasonable, and then I'd get rid of the special-case 'ring' functions.

  -- Keir