From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH][TOOLS] Reducing impact ofdomainsave/restore/dump on Dom0 Date: Wed, 21 Feb 2007 15:10:21 +0000 Message-ID: References: <342BAC0A5467384983B586A6B0B3767104BE068C@EXNA.corp.stratus.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <342BAC0A5467384983B586A6B0B3767104BE068C@EXNA.corp.stratus.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Graham, Simon" , Keir Fraser , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 21/2/07 15:06, "Graham, Simon" wrote: > 2. sync-then-advise is only done at the end of writing a file to ensure > that all > of the cached pages are discarded. Whilst writing the file, I only > fadvise > which triggers a write back and discards any clean pages up to the > specified offset. > This is indeed a performance thing -- fsyncing on every write makes > it very slow. Do you need the fsync at all? It's possible that the kernel will launder-then-discard the affected pages automatically, just from the fadvise() alone. -- Keir