From: Keir Fraser <keir@xensource.com>
To: PUCCETTI Armand <armand.puccetti@cea.fr>, xen-devel@lists.xensource.com
Subject: Re: frame_table initialisation
Date: Mon, 26 Feb 2007 16:02:12 +0000 [thread overview]
Message-ID: <C208B504.A29F%keir@xensource.com> (raw)
In-Reply-To: <45E2F29A.2020601@cea.fr>
On 26/2/07 14:45, "PUCCETTI Armand" <armand.puccetti@cea.fr> wrote:
> 2. some lines before in __start_xen, this variable is referenced by
> function map_pages_to_xen -> virt_to_xen_l2 -> alloc_xen_pagetable ->
> mfn_to_page.
> What should the value of frame_table be there?
>
> Do I miss some pre-initialisation(s)?
The fact that frame_table is not initialised here (and hence will be NULL)
doesn't actually matter, since the result of mfn_to_page() is only actually
used as a value to page_to_mfn(). And page_to_mfn(mfn_to_page(m))==m for any
(constant) value of frame_table.
This code could be clearer I'll admit. It probably makes sense for
alloc_xen_pagetable to return an MFN rather than a page_info pointer.
-- Keir
prev parent reply other threads:[~2007-02-26 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 14:45 frame_table initialisation PUCCETTI Armand
2007-02-26 16:02 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C208B504.A29F%keir@xensource.com \
--to=keir@xensource.com \
--cc=armand.puccetti@cea.fr \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.