From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] Make x86_64 swiotlb code to support
	dma_ops [2/2]
Date: Wed, 28 Feb 2007 21:23:40 +0000
Message-ID: <C20BA35C.3094%keir@xensource.com>
References: <1449F58C868D8D4E9C72945771150BDFD96682@SAUSEXMB1.amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1449F58C868D8D4E9C72945771150BDFD96682@SAUSEXMB1.amd.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Langsdorf, Mark" <mark.langsdorf@amd.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 28/2/07 20:17, "Langsdorf, Mark" <mark.langsdorf@amd.com> wrote:

> The first patch creates the arch/x86_64/kernel/pci-dma-xen.c
> file based on the standard pci-dma.c, and creates
> arch/x86_64/kernel/swiotlb-xen.c based on
> arch/i386/kernel/swiotlb.c.

Do we really need to duplicate the swiotlb code? Did you need to make big
changes?

Other points that I can see from a quick browse include the fact that
alloc_coherent() still looks broken afaics and the one-liner in
io_apic-xen.c is a bit random (since none of the other use-iommu-or-not
decision points are changed, and the GART stuff which is presumably what is
being kludged around is not even included in Xen builds yet).

 -- Keir