From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2] Date: Wed, 28 Feb 2007 21:43:07 +0000 Message-ID: References: <1449F58C868D8D4E9C72945771150BDFD9668D@SAUSEXMB1.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449F58C868D8D4E9C72945771150BDFD9668D@SAUSEXMB1.amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Langsdorf, Mark" , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 28/2/07 21:35, "Langsdorf, Mark" wrote: >> Other points that I can see from a quick browse include the fact that >> alloc_coherent() still looks broken afaics > > The i386 swiotlb implementation doesn't seem to have an > alloc_coherent(). Since all this patch is intended to do > is move swiotlb into the x86_64 directory, I'm not sure > how to resolve the broken implementation. By pulling in a new arch/x86_64/pci-dma-xen.c you are replacing the implementations of things like dma_alloc_coherent(). These replacements, being pretty much unmodified from the x86/64 native originals, simply aren't going to work on Xen. I'm not sure how far we'll need to deviate -- I suspect we'll end up with a file that look much like the i386/pci-dma-xen.c but with calls to swiotlb_xxx() replaced with dma_ops->xxx. Maybe we could even stick with just i386/pci-dma-xen.c and macro up the uses of swiotlb_xxx() (so that they can be replaced with uses of dma_ops->xxx for x86/64 by cpp). -- Keir