From: Keir Fraser <keir@xensource.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] linux/x86-64: allow kernel init memory to be freed
Date: Fri, 02 Mar 2007 15:23:40 +0000 [thread overview]
Message-ID: <C20DF1FC.A826%keir@xensource.com> (raw)
In-Reply-To: <45E812E4.76E4.0078.0@novell.com>
On 2/3/07 11:04, "Jan Beulich" <jbeulich@novell.com> wrote:
> + if (addr >= __START_KERNEL_map) {
> + /* make_readonly() reports all kernel addresses. */
> + __make_page_writable(__va(__pa(addr)));
> + __make_page_readonly((void *)addr);
> + }
I'm confused by this:
1. Why does the write-protection need to be changed unconditionally, or
even at all? Is there anything write-protected in the init sections?
2. Is it safe to keep init mappings above START_KERNEL_map at all, even
read-only? I'd have thought we'd be in trouble if the balloon driver manages
to allocate those pages and tries to free them to Xen. Perhaps they should
be blown away entirely?
-- Keir
next prev parent reply other threads:[~2007-03-02 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 11:04 [PATCH] linux/x86-64: allow kernel init memory to be freed Jan Beulich
2007-03-02 15:23 ` Keir Fraser [this message]
2007-03-02 16:01 ` Jan Beulich
2007-03-02 16:19 ` Keir Fraser
2007-03-05 9:51 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C20DF1FC.A826%keir@xensource.com \
--to=keir@xensource.com \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.