From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 8/8] 2.6.17: scan DMI early Date: Mon, 05 Mar 2007 15:51:54 +0000 Message-ID: References: <45D34049.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45D34049.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 14/2/07 16:00, "Jan Beulich" wrote: > While shuffling quite a few things around, this gets us closer to native, > which clearly had a reason to do the DMI scan early. > > Signed-off-by: Jan Beulich Taken, but a few comments: - could we get rid of alloc_static_page() and use spp_getpage() everywhere? - the double-staged find_early_table_space(), where table_end gets updated halfway through init_memory_mapping(), is pretty skanky. I suppose we get to keep the BUG_ON(start_pfn != table_end) this way, but perhaps it would be nicer just to set table_end once and for all in find_early_table_space(). - the estimate of number of fixmap pagetables required in find_early_table_space() is conservative. Is there any risk that spp_getpage() may end up with start_pfn