From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: page ownership
Date: Thu, 08 Mar 2007 10:23:15 +0000
Message-ID: <C2159493.B068%keir@xensource.com>
References: <45EFEF3B.76E4.0078.0@novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <45EFEF3B.76E4.0078.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 8/3/07 10:10, "Jan Beulich" <jbeulich@novell.com> wrote:

> Is there a particular reason why page_set_owner(pg, NULL) is
> - not used in free_domheap_pages()?

It's done in __alloc_domheap_pages() instead. Arguably moving it would be
cleaner.

> - only used on pages 1 ... ((1 << order) - 1) in __alloc_domheap_pages()?

Page 0 is done outside the loop, and writes directly to _domain for no
particularly good reason. I guess I implemented the first iteration outside
the loop to special-case initialisation of the tlbflush cpumask. Which
probably isn't a very worthwhile optimisation, to be honest.

I'll do a little cleanup here. It would certainly be sane to not have random
domain pointers hanging around in freed pages.

 -- Keir