From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: mini-os: C programming
Date: Thu, 15 Mar 2007 13:54:06 +0000
Message-ID: <C21F007E.B8C1%keir@xensource.com>
References: <45F94C89.4010603@cea.fr>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <45F94C89.4010603@cea.fr>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: PUCCETTI Armand <armand.puccetti@cea.fr>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 15/3/07 13:39, "PUCCETTI Armand" <armand.puccetti@cea.fr> wrote:

> extern char *stack;

Yes, this one is bogus.

> 2. In file xen-3.0.3/extras/mini-os/gnttab.c:140: the const variable
> gnttabop_error_msgs
> is declared as
> 
> static const char *gnttabop_error_msgs[] = GNTTABOP_error_msgs;
> 
> shouldn't that instead be declared:
> 
> static const char * const gnttabop_error_msgs[] = GNTTABOP_error_msgs;

It doesn't really matter, does it? Personally I hate scattering 'const' all
over the place.

 -- Keir