From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 0/3] [RFC] User-space grant table device Date: Mon, 19 Mar 2007 14:00:29 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Derek Murray , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 19/3/07 10:40, "Derek Murray" wrote: > 1. gntdev.patch: This is the main driver, and associated header file. > 2. libxc-changes.patch: These are the libxc functions for accessing > the driver. > 3. linux-changes.patch: These contain the necessary changes to linux > (in effect, adding a hook to the vm_operations_struct that is called > by the unmap_page_range function) for unmapping grants before the > page table is destroyed. 1. The patches are malformed (don't apply). It might be best to send the patches at plain-text attachments to prevent mangling by your email client. 2. Dependencies should be listed in the right order. So your patch 3 should be patch 1, since it is required by the grant-table device. 3. Just looking at linux-changes.patch, I think the new interface function's semantics need to be clearer. Do you really mean for the hook function to be called *and* for unmap_page_range() to do the usual zap_pud_range() work? Should the hook function return anything? What about responsibility for synchronising TLBs? -- Keir