Re: [PATCH] Proper use of VMX execution controls MSR.

[Keir Fraser <keir@xensource.com>]

On 29/3/07 09:37, "Li, Xin B" <xin.b.li@intel.com> wrote:

> if we have the feature support in Xen, we should set the input control
> bit, and expect the adjusted value to be 1;
> if we don't have the feature support in Xen, we should clear the input
> control bit, and expect adjusted value to be 0;
> That's meaning the adjusted output is determined by the input control.
> So the expression should be "AND (msr_hi XOR msr_lo)".

The subsequent AND with msr_hi and the OR with msr_lo has exactly the same
effect. So the AND (msr_hi XOR msr_lo) is not incorrect, but it is
redundant.

 -- Keir