From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH][HVM] fix VNIF restore failure on HVM guest with heavy workload Date: Tue, 10 Apr 2007 20:16:04 +0100 Message-ID: References: <20070410164738.GA24587@edwin-gen.ccr> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070410164738.GA24587@edwin-gen.ccr> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Zhai, Edwin" , Ian Pratt , Tim Deegan Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 10/4/07 17:47, "Zhai, Edwin" wrote: > [PATCH][HVM] fix VNIF restore failure on HVM guest with heavy workload > > Signed-off-by: Zhai Edwin > > VNIF has many intrs when save/restore with net workload, so need keep handler > from intrs What happens if an interrupt is being processed during save/restore? It would be nice to know what the underlying bug is! That said, it may well make sense to somehow disable interrupt handling across save/restore. Unfortunately your patch is insufficient since we could handle event-channel interrupts on any VCPU (the irq's affinity can be changed outside our control if it is routed through the virtual IOAPIC, and if e.g. the userspace irqbalance daemon is running). I wanted to use stop_machine_run() but unfortunately it isn't exported to modules. :-( irq_disable() may do the right thing for us though. -- Keir