All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: "Petersson, Mats" <Mats.Petersson@amd.com>,
	xen-devel@lists.xensource.com
Subject: Re: RE: [Xen-staging] [xen-unstable] hvm rombios: Fix int15, func 0x86 (udelay).
Date: Tue, 24 Apr 2007 13:46:44 +0100	[thread overview]
Message-ID: <C253BAC4.DC3E%keir@xensource.com> (raw)
In-Reply-To: <907625E08839C4409CE5768403633E0B018E1C51@sefsexmb1.amd.com>




On 24/4/07 12:19, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:

> Minor nit: You don't need SEG_SS if you're using bp, as bp defaults to
> SS segment. 
>>        shl  eax, #16
>>        SEG SS
>> -        mov  ax, _int15_function.DX [bx]
>> +        mov  ax, .int15_function32.DX [bp]
> As above.

Oh yes, I missed that simplification.

 -- Keir

      reply	other threads:[~2007-04-24 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200704241116.l3OBGMPh031604@latara.uk.xensource.com>
2007-04-24 11:19 ` [Xen-staging] [xen-unstable] hvm rombios: Fix int15, func 0x86 (udelay) Petersson, Mats
2007-04-24 12:46   ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C253BAC4.DC3E%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=Mats.Petersson@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.