From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] [Xen] [ACM] Code restructuring Date: Tue, 24 Apr 2007 16:55:51 +0100 Message-ID: References: <1177431435.4153.8.camel@gsal-3.watson.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1177431435.4153.8.camel@gsal-3.watson.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefan Berger , xen-devel List-Id: xen-devel@lists.xenproject.org Much nicer, thank you. I've applied it for 3.0.5. However, given the effort put in to labelling a domain at the very start of its lifetime, wouldn't it be a good idea to leave that label attached until the domain is actually destroyed? This would correspond to putting the destructor call in domain_destroy() or, even better, complete_domain_destroy(). Bear in mind that a domain may still be accessible and have resources allocated to it even after domain_kill() finishes executing. So stripping its resource label at that point in time is a bit worrying. -- Keir On 24/4/07 17:17, "Stefan Berger" wrote: > This patch restructures part of the ACM code in Xen. When a domain is > created, the function acm_domain_create() in domain_create() is called > that does what previously the pre- and post_domain_create functions were > doing. Similarly there's a function acm_domain_destroy() in > domain_kill() that reverts changes to state when destroying a domain. > There's no more separate initialization necessary for domain-0, but > domain_create takes one more parameter, the ssidref. It is usually > passed through the hypercall when a domain is created. > > Signed-off-by: Stefan Berger