From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] Segments can span multiple clusters with
	tap:qcow
Date: Thu, 26 Apr 2007 11:00:54 +0100
Message-ID: <C25636E6.DF42%keir@xensource.com>
References: <1177579115.3487.27.camel@blaa>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1177579115.3487.27.camel@blaa>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Mark McLoughlin <markmc@redhat.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 26/4/07 10:18, "Mark McLoughlin" <markmc@redhat.com> wrote:

>> The current code allocates aio-request info for every segment in a request
>> ring (MAX_AIO_REQUESTS == BLK_RING_SIZE * MAX_SEGMENTS_PER_REQUEST). This
>> patch seems to take into account that each segment (part-of-page) can itself
>> be split into clusters, hence the page_size/cluster_size calculation, but
>> shouldn't this be multiplied by the existing MAX_AIO_REQUESTS? Otherwise you
>> provide only enough aio requests for one segment at a time, rather than a
>> request ring's worth of segments?
> 
> Absolutely, well spotted. I fixed that typo after testing, but
> obviously forgot to run "quilt refresh" before sending ...
> 
> Fixed version attached.

This one doesn't build (free_aio_state: line 164: structure has no member
named 'private'). Perhaps free_aio_state() should take a 'struct
disk_driver' rather than a 'struct td_state'?

 -- Keir