From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Re: [PATCH] [ACM] Comilation fix for 32 bit Date: Thu, 26 Apr 2007 11:55:06 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1706340533==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefan Berger Cc: xen-devel List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --===============1706340533== Content-type: multipart/alternative; boundary="B_3260433307_18950251" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3260433307_18950251 Content-type: text/plain; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable On 26/4/07 11:49, "Stefan Berger" wrote: >> > You're better off keeping the GUEST_HANDLE_64() and getting rid of the >> > compat acm stuff. As far as I can see, all your interfaces are *curren= tly* >> > 32/64-bit invariant. So the compat stuff can safely be removed and the= n you >> > don't need to continually keep it sync. >=20 > I was going to ask you about this. I am writing on a patch that puts all = the > ACM hypercall structures into a union. I am wondering what the compat stu= ff is > for (xen/common/compat) and what the criterion is for needing this compat > code.=20 >=20 If you have structures that differ in layout in 32-bit mode vs. 64-bit mode then you need a compat shim when running 32-bit dom0 on 64-bit Xen (which w= e support doing nowadays). Currently you have no such issues that I=B9m aware of. You should be able to delete the compat stuff that is there currently with no problems. Is the build failure in Xen itself or in tools? I=B9m sure it=B9s easily fixed without needing to throw away the GUEST_HANDLE_64() usage. -- Keir --B_3260433307_18950251 Content-type: text/html; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Re: [Xen-devel] Re: [PATCH] [ACM] Comilation fix for 32 bit On 26= /4/07 11:49, "Stefan Berger" <stefanb@us.ibm.com> wrote:

> You're better off keeping the GUEST_HANDLE_64() and gett= ing rid of the
> compat acm stuff. As far as I can see, all your interfaces are *curren= tly*
> 32/64-bit invariant. So the compat stuff can safely be removed and the= n you
> don't need to continually keep it sync.

I was going to ask you about this. = I am writing on a patch that puts all the ACM hypercall structures into a un= ion. I am wondering what the compat stuff is for (xen/common/compat) and wha= t the criterion is for needing this compat code.

If you have structures that differ in layout in 32-bit mode = vs. 64-bit mode then you need a compat shim when running 32-bit dom0 on 64-b= it Xen (which we support doing nowadays). Currently you have no such issues = that I’m aware of. You should be able to delete the compat stuff that = is there currently with no problems.

Is the build failure in Xen itself or in tools? I’m sure it’s e= asily fixed without needing to throw away the GUEST_HANDLE_64() usage.

 -- Keir
 --B_3260433307_18950251-- --===============1706340533== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1706340533==--