From: Keir Fraser <keir@xensource.com>
To: "Petersson, Mats" <Mats.Petersson@amd.com>,
xen-devel@lists.xensource.com
Subject: Re: "kobject add failed"
Date: Thu, 03 May 2007 18:26:41 +0100 [thread overview]
Message-ID: <C25FD9E1.E5E0%keir@xensource.com> (raw)
In-Reply-To: <907625E08839C4409CE5768403633E0B018E1CC4@sefsexmb1.amd.com>
On 3/5/07 18:19, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:
>> However, the invocation of tun_set_iff() is wrapped in
>> rtnl_lock()/unlock()
>> so should be concurrency safe. Still, this is where I would
>> concentrate my
>> search if I were you.
>
> Indeed, the tun_set_iff() is protected by rtnl_lock/unlock()... Any
> reason to believe that doesn't work?
Your crash report. :-)
However tun_set_iff() is not in the oops backtrace... Perhaps I'm wrong
about which ioctl is being executed, or the path taken through the Linux
kernel.
However, it definitely does look like a lack of locking around picking a
device name and registering it. I'm fairly confident that this will turn out
to be the problem. You might want to add some tracing to the kernel to find
out what paths you take during qemu-dm startup (this might cause the race
not to happen any more, but you can remove the tracing once you know which
functions you should be staring at).
-- Keir
next prev parent reply other threads:[~2007-05-03 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 15:39 "kobject add failed" Petersson, Mats
2007-05-03 16:40 ` Keir Fraser
2007-05-03 16:45 ` Petersson, Mats
2007-05-03 17:03 ` Keir Fraser
2007-05-03 17:19 ` Petersson, Mats
2007-05-03 17:26 ` Keir Fraser [this message]
2007-05-03 17:37 ` Petersson, Mats
2007-05-14 16:37 ` Petersson, Mats
2007-05-15 12:49 ` [PATCH][RFC] "kobject add failed" Suggested workaround Petersson, Mats
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C25FD9E1.E5E0%keir@xensource.com \
--to=keir@xensource.com \
--cc=Mats.Petersson@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.