All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: NMI deferral on i386
Date: Tue, 15 May 2007 16:00:32 +0100	[thread overview]
Message-ID: <C26F89A0.EF8C%keir@xensource.com> (raw)
In-Reply-To: <4649E3C8.76E4.0078.0@novell.com>

On 15/5/07 15:46, "Jan Beulich" <jbeulich@novell.com> wrote:

> - by using iret, the NMI is being acknowledged to the CPU, and since nothing
>   was done to address its reason, I can't see why it shouldn't re-trigger
>   right after that iret (unless it was sent as an IPI)

Yes, it's good enough for watchdog and oprofile. Level-triggered external
NMIs will of course be a problem. We could possibly work around this by
masking LINT1 if we are CPU0 (and, of course, if LAPIC is enabled) and then
unmasking only at the end of real NMI handler. And of course x86/64 doesn't
have this problem at all, and practically speaking is pretty much the only
hypervisor build that vendors seem to care about.

> - by re-issuing it on vector 31, the resulting interrupt will have lower
> priority
>   than any external interrupt, hence all pending interrupts will be serviced
>   before getting to actually handle the NMI; ideally this should use the
> highest
>   possible vector, but since priorities are grouped anyway, at least
> allocating
>   the vector from the high priority pool would seem necessary

Yes, this is true.

 -- Keir

  reply	other threads:[~2007-05-15 15:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15 14:46 NMI deferral on i386 Jan Beulich
2007-05-15 15:00 ` Keir Fraser [this message]
2007-05-16  8:17   ` Jan Beulich
2007-05-16  8:28     ` Keir Fraser
2007-05-16 10:10       ` Jan Beulich
2007-05-16 12:32         ` Keir Fraser
2007-05-16 14:19           ` Jan Beulich
2007-05-21 14:01       ` Jan Beulich
2007-05-21 14:17         ` Keir Fraser
2007-05-21 14:34           ` Jan Beulich
2007-05-23 10:03             ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C26F89A0.EF8C%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.