Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

[Petersson, Mats]

It seems like something is missing in the _releaseDevices, and I think
the correct way to fix it would be to call destroyDevice - is there any
reason I shouldn't use that function, rather than the current method of
removing (some of) the device info from XenStore in _releaseDevices?

--
Mats

Re: Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

[Keir Fraser]

This is how it looks to me too! Unless Ewan or Tom knows better, this is
probably worth trying out. It would be a neater solution for the console
backend cleanup than your hacky patch, if it works.

 -- Keir

On 16/5/07 13:04, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:

> It seems like something is missing in the _releaseDevices, and I think
> the correct way to fix it would be to call destroyDevice - is there any
> reason I shouldn't use that function, rather than the current method of
> removing (some of) the device info from XenStore in _releaseDevices?
> 
> --
> Mats
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

[Tom Wilkie]

It would make sense, I was going to give it a test but never got  
round to it.  Feel free to try it out

Tom

On 16 May 2007, at 13:33, Keir Fraser wrote:

> This is how it looks to me too! Unless Ewan or Tom knows better,  
> this is
> probably worth trying out. It would be a neater solution for the  
> console
> backend cleanup than your hacky patch, if it works.
>
>  -- Keir
>
> On 16/5/07 13:04, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:
>
>> It seems like something is missing in the _releaseDevices, and I  
>> think
>> the correct way to fix it would be to call destroyDevice - is  
>> there any
>> reason I shouldn't use that function, rather than the current  
>> method of
>> removing (some of) the device info from XenStore in _releaseDevices?
>>
>> --
>> Mats
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

RE: Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

[Petersson, Mats]

 

> -----Original Message-----
> From: Keir Fraser [mailto:keir@xensource.com] 
> Sent: 16 May 2007 13:34
> To: Petersson, Mats; xen-devel@lists.xensource.com
> Subject: Re: [Xen-devel] Shouldn't XendDomainInfo.py: 
> _releaseDevices call destroyDevice?
> 
> This is how it looks to me too! Unless Ewan or Tom knows 
> better, this is
> probably worth trying out. It would be a neater solution for 
> the console
> backend cleanup than your hacky patch, if it works.

Yes, particularly since my hacky patch doesn't actually work for all the
cases, which is why I started looking at it again [the xenstore still
grows, but not quite as quickly].   :-(

Now, this brings a question: The _releaseDevices attempts to remove all
devices as one transaction, but calling destroyDevices for each device
would of course make it into multiple transactions. Is there any reason
why this would make it a problem?

--
Mats

> 
>  -- Keir
> 
> On 16/5/07 13:04, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:
> 
> > It seems like something is missing in the _releaseDevices, 
> and I think
> > the correct way to fix it would be to call destroyDevice - 
> is there any
> > reason I shouldn't use that function, rather than the 
> current method of
> > removing (some of) the device info from XenStore in _releaseDevices?
> > 
> > --
> > Mats
> > 
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> 
> 
> 
> 

Re: Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

[Keir Fraser]

On 16/5/07 14:23, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:

> Now, this brings a question: The _releaseDevices attempts to remove all
> devices as one transaction, but calling destroyDevices for each device
> would of course make it into multiple transactions. Is there any reason
> why this would make it a problem?

No. I'm pretty certain not.

 K.

RE: Shouldn't XendDomainInfo.py: _releaseDevices call destroyDevice?

[Petersson, Mats]

> -----Original Message-----
> From: Keir Fraser [mailto:keir@xensource.com] 
> Sent: 16 May 2007 14:42
> To: Petersson, Mats; xen-devel@lists.xensource.com
> Subject: Re: [Xen-devel] Shouldn't XendDomainInfo.py: 
> _releaseDevices call destroyDevice?
> 
> 
> 
> 
> On 16/5/07 14:23, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:
> 
> > Now, this brings a question: The _releaseDevices attempts 
> to remove all
> > devices as one transaction, but calling destroyDevices for 
> each device
> > would of course make it into multiple transactions. Is 
> there any reason
> > why this would make it a problem?
> 
> No. I'm pretty certain not.

Ok, so I hacked up a changed version, but it seems like the
destroyDevice() function in XendDomainInfo.py isn't working right - it's
trying to read an entry called "dev" in the backend info, and there's no
such thing in my store. Anyone have an idea of what it SHOULD read?
"frontend-id" seems a likely candidate, but I'm not sure if that's the
right thing or not.

--
Mats
> 
>  K.
> 
> 
> 
>