From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 0/4] HVM Virtual S3 Date: Fri, 18 May 2007 07:43:54 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Tian, Kevin" , "Yu, Ke" , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 18/5/07 03:38, "Tian, Kevin" wrote: > I doubt whether this will bring some tricky issues if Qemu happens > to inject some event after Xen's reset but before Qemu's reset. If > that event results a stale pending interrupt after Xen resets vPIC or > vIOAPIC, will that result a spurious interrupt after HVM is resumed? > By current style, Qemu first reset all virtual devices and thus stop > interrupt sources. Then it's safe to let Xen do a full reset subsequently. > > Also normally the reason to put Qemu logic into Xen is for performance. For > virtual S3 interception, it doesn't matter since only resume time is > the concern. > > Just doubt whether it's worthy of such split anyway. :-) Okay, let's rename this s3_suspend hypercall to system_reset instead, and leave it that. -- Keir