From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] [xm] Fix vncdisplay for hvm guests
Date: Thu, 24 May 2007 15:31:44 +0100
Message-ID: <C27B6060.F751%keir@xensource.com>
References: <464A3ED1.1010904@novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <464A3ED1.1010904@novell.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jim Fehlig <jfehlig@novell.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org




On 16/5/07 00:14, "Jim Fehlig" <jfehlig@novell.com> wrote:

> results in '-vncunused' being passed to qemu-dm.  There are several
> approaches
> for a fix - this patch defaults vncdisplay to None in xm options.  It
> currently defaults to 1 and is always included in the image config
> created by configure_hvm() in tools/python/xen/xm/create.py.  In xend
> (tools/python/xen/xend/image.py - parseDeviceModelArgs), vncunused takes
> precedence over vncdisplay.

Looks like it changes vncunused default rather than vncdisplay. Wouldn't the
preferred default be to keep vncunused=1?

 -- Keir