From: Keir Fraser <keir@xensource.com>
To: "Petersson, Mats" <Mats.Petersson@amd.com>,
xen-devel@lists.xensource.com
Subject: Re: [PATCH][XEND]Fix checkname so that it detects duplicate domains.
Date: Fri, 25 May 2007 10:39:37 +0100 [thread overview]
Message-ID: <C27C6D69.F7FC%keir@xensource.com> (raw)
In-Reply-To: <907625E08839C4409CE5768403633E0B02561D37@sefsexmb1.amd.com>
On 25/5/07 10:25, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:
>> If we don't enforce UUID uniqueness, what is the point of
>> having a UUID?
>> Also, don't we store some VM information in /vm/<uuid> in
>> xenstore: how does
>> that work out if we have multiple domains with the same UUID?
>
> All very good points. I don't actually know how this is meant to work,
> I'm just fixing an apparent bug, which is that if the UUID is
> duplicated, you can have two domains with the same name, which isn't
> what is supposed to happen. There should probably ALSO be a "_checkuuid"
> function to verify that the UUID is unique. Not sure it's my place to
> fix that, tho'?
Oh. Your patch comment strongly implies that the current behaviour of xend
is to check for UUID uniqueness, and that you are changing this to a check
for name uniqueness. And that looks like what this patch does, too.
But here you seem to be saying that xend enforces neither UUID uniqueness
nor name uniqueness?
-- Keir
next prev parent reply other threads:[~2007-05-25 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 9:57 [PATCH][XEND]Fix checkname so that it detects duplicate domains Petersson, Mats
2007-05-25 9:20 ` Keir Fraser
2007-05-25 9:25 ` Petersson, Mats
2007-05-25 9:39 ` Keir Fraser [this message]
2007-05-25 9:44 ` Petersson, Mats
2007-05-25 9:51 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C27C6D69.F7FC%keir@xensource.com \
--to=keir@xensource.com \
--cc=Mats.Petersson@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.