All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: "Tian, Kevin" <kevin.tian@intel.com>, Guy Zana <guy@neocleus.com>,
	"Kay, Allen M" <allen.m.kay@intel.com>,
	xen-devel@lists.xensource.com
Subject: Re: [VTD][patch 0/5] HVM device assignment using vt-d
Date: Thu, 31 May 2007 16:40:04 +0100	[thread overview]
Message-ID: <C284AAE4.FCB7%keir@xensource.com> (raw)
In-Reply-To: <D470B4E54465E3469E2ABBC5AFAC390F013B1EB6@pdsmsx412.ccr.corp.intel.com>

On 31/5/07 16:30, "Tian, Kevin" <kevin.tian@intel.com> wrote:

> OK, my rough thought is as below:
> 
> The reason to change polarity, IMO, is to capture the de-assert
> edge in the physical wire and then reflect de-assertion into the virtual
> wire. Then allow the statistics on gsi_assert_count to be updated
> correctly, when shared with virtual devices in Qemu.
> 
> My proposal is to take virtual EOI as the de-assertion hint, without
> any change on physical RTE property like polarity. For example, the
> flow could be following by keeping a saying hw_assert_status array for
> all virtual GSIs: (take vioapic for example)

Ah, okay, so no polarity switching at all. Basically use VIOAPIC EOI as a
hint to tentatively drop the virtual wire to LOW, and only then ->end the
physical interrupt. I guess this is pretty much what you already implement
in your VT-d patches?

It'd be interesting to know how these two approaches compare
performance-wise. I suppose yours should win, really, due to fewer physical
interrupts.

If this is how your current VT-d patches handle interrupts then I don't see
why ioapic_ack=new is not working for you. That's a bit weird. I guess I
could read the patches some more. ;-)

 -- Keir

  reply	other threads:[~2007-05-31 15:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-30 19:05 [VTD][patch 0/5] HVM device assignment using vt-d Kay, Allen M
2007-05-30 19:55 ` Keir Fraser
2007-05-30 22:02   ` Kay, Allen M
2007-05-31  6:49     ` Keir Fraser
2007-05-31  6:05   ` Guy Zana
2007-05-31 13:20     ` Tian, Kevin
2007-05-31 13:37       ` Keir Fraser
2007-05-31 13:59         ` Tian, Kevin
2007-05-31 15:03           ` Keir Fraser
2007-05-31 15:10             ` Tian, Kevin
2007-05-31 15:14               ` Keir Fraser
2007-05-31 15:30                 ` Tian, Kevin
2007-05-31 15:40                   ` Keir Fraser [this message]
2007-05-31 15:51                     ` Tian, Kevin
2007-05-31 15:52                     ` Keir Fraser
2007-05-31 15:59                       ` Tian, Kevin
2007-05-31 16:03                         ` Tian, Kevin
2007-05-31 16:07                           ` Guy Zana
2007-05-31 16:28                         ` Keir Fraser
2007-06-01  2:57                       ` Tian, Kevin
2007-05-31 14:08       ` Guy Zana
2007-05-31 17:43     ` Kay, Allen M
2007-05-31 18:00       ` Guy Zana
2007-05-31 18:42         ` Kay, Allen M
2007-06-03  8:29     ` Kay, Allen M
2007-06-03  8:37       ` Keir Fraser
2007-06-03  9:59       ` Guy Zana
2007-06-03 13:29         ` Tian, Kevin
2007-06-03 13:35           ` Keir Fraser
2007-06-03 14:35           ` Guy Zana
2007-06-04 22:56         ` Kay, Allen M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C284AAE4.FCB7%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=allen.m.kay@intel.com \
    --cc=guy@neocleus.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.