From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Merging PCI pass-through code Date: Mon, 04 Jun 2007 10:44:37 +0100 Message-ID: References: <9392A06CB0FDC847B3A530B3DC174E7B02ADC595@mse10be1.mse10.exchange.ms> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1612895182==" Return-path: In-Reply-To: <9392A06CB0FDC847B3A530B3DC174E7B02ADC595@mse10be1.mse10.exchange.ms> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Guy Zana , "Kay, Allen M" , "Tian, Kevin" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --===============1612895182== Content-type: multipart/alternative; boundary="B_3263798677_145767" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3263798677_145767 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit On 3/6/07 17:52, "Guy Zana" wrote: > Since both Neocleus' solution & Intel's solution have overlapping > implementations, we should determine what should stays and what goes. > There is a question on how should we do the merge? > I like the idea of a separate tree, just for the short term, as a shared workspace for merging and development and bug fixing. I can arrange to create a new repo called xen-hvm-directio.hg (or a better name if you can think of one)? From the list of points below it sounds like both sets of patches need some work, quite apart from the required merging. Would this method of development suit everyone? -- Keir > > Here are a number of issues that we should address: > > 1. We should really create a separate tree and have the merging done outside > of the main unstable tree. > 2. Neocleus will use your configuration interface to assign pci devices. > 3.1 The lpci library - I think it is best to merge Intel's code with what we > have in our implementation of libpci, and you can add your functions to our > library. > 3.2 Your implementation doesn't read/write to the real PCI config space, I'm > not sure that all devices would like that :) > 4. Pass-through initialization should be done regardless of an iommu present. > 5. What type of interrupt handling is the way to go? I can't compare the > polarity-change with your method since I don't have an IOMMU machine... > 6. Does the PIO/MMIO access functions in qemu-dm (Neocleus') are needed? (It's > good for debugging) > 7. The 1:1 mapping and specific-iommu code can be merged separately. > --B_3263798677_145767 Content-type: text/html; charset="US-ASCII" Content-transfer-encoding: quoted-printable Re: [Xen-devel] Merging PCI pass-through code On 3/= 6/07 17:52, "Guy Zana" <guy@neocleus.com> wrote:

Since both Neocleus' solution & Intel's solution have overlapping imple= mentations, we should determine what should stays and what goes.
There is a question on how should we do the merge?
I like the idea of a separate tree, just for the short= term, as a shared workspace for merging and development and bug fixing. I c= an arrange to create a new repo called xen-hvm-directio.hg (or a better name= if you can think of one)? From the list of points below it sounds like both= sets of patches need some work, quite apart from the required merging. Woul= d this method of development suit everyone?

 -- Keir

Here are a number of issues that we should addres= s:
1. We should really create a separate tree and ha= ve the merging done outside of the main unstable tree.
2. Neocleus will use your configuration interface to assign pci devices. 3.1 The lpci library - I think it is best to merge Intel's code with what w= e have in our implementation of libpci, and you can add your functions to ou= r library.
3.2 Your implementation doesn't read/write to the real PCI config space, I'= m not sure that all devices would like that :)
4. Pass-through initialization should be done regardless of an iommu presen= t.
5. What type of interrupt handling is the way to go? I can't compare the po= larity-change with your method since I don't have an IOMMU machine...
6. Does the PIO/MMIO access functions in qemu-dm (Neocleus') are needed? (I= t's good for debugging)
7. The 1:1 mapping and specific-iommu code can be merged separately.
 

 --B_3263798677_145767-- --===============1612895182== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1612895182==--