From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: PATCH: Add persistent guest & hv logging in xenconsoled Date: Mon, 04 Jun 2007 15:07:28 +0100 Message-ID: References: <20070604135220.GD17323@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070604135220.GD17323@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 4/6/07 14:52, "Daniel P. Berrange" wrote: >> Also, shouldn't the writes to log files be non-blocking, and those fds be >> added to the select set when there is data waiting to be written? > > IIRC, if you select() on a local file handle it'll always be shown writable > so I don't believe it'll be any use. The kernel code appears to agree with you! Fair enough then. -- Keir