From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Add callgraph support to Xenoprofile Date: Thu, 07 Jun 2007 10:30:38 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Amitabha Roy Cc: Xen developers mailing list , "Santos, Jose Renato G" List-Id: xen-devel@lists.xenproject.org On 7/6/07 10:20, "Amitabha Roy" wrote: > Coding style is likely because I've preserved the formatting of the > original files (esp. of backtrace.c from Linux for simple diffs). > There isnt a consistent style across the files that I could follow. Linux-derived files follow Linux style (this will apply to many of the files under arch/x86/oprofile). Xen-specific files follow Xen style as in e.g., page_alloc.c, xmalloc.c, xenoprof.c). If any of the files you edit don't follow this, please fix them first, and send a separate patch as a prerequisite for your own. > CONFIG_FRAME_POINTER gets used in config/StdGNU.mk. > I simply followed whatever was done for XEN_TARGET_X86_PAE. However > unlike the PAE case I haven't ensured that frame pointers are turned > on both in the kernel and Xen. If you want I can move all the frame > pointer related stuff into xen/Rules.mk. Yes, please. Call the option frame_pointer, in line with other Xen-specific options which are also lower case. -- Keir