All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86: introduce specialized clear_page()
Date: Wed, 20 Jun 2007 16:16:00 +0100	[thread overview]
Message-ID: <C29F0340.10F41%keir@xensource.com> (raw)
In-Reply-To: <4677C925.76E4.0078.0@novell.com>

On 19/6/07 11:16, "Jan Beulich" <jbeulich@novell.com> wrote:

> While the patch also adds an SSE version, this is is currently orphaned
> as I am not certain about the benefit of special casing idle VCPUs in
> a few places (during context switching), so that at least in that
> context using %xmmN registers would be possible without crashing and/or
> corrupting guest state. The benefit of adding such support could be to
> reduce scheduling latency when a VCPU is to transition out of idle, but
> is busy doing page cleaning.

I measure no benefit from the XMM version (nor from upgrading the SSE2
version on x86/64 to clear from %rax instead of %eax). I guess this is
because the move is non-temporal and it's actually quite easy to max the
memory bandwidth.

So I stripped out the xmm version (it can't work anyway without some
kernel_fpu_begin/end kind of mechanism) and made the sse2 version common
across i386 and x86_64 since that was easily done and increases code
sharing.

 -- Keir

  reply	other threads:[~2007-06-20 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 10:16 [PATCH] x86: introduce specialized clear_page() Jan Beulich
2007-06-20 15:16 ` Keir Fraser [this message]
2007-06-20 15:35   ` Jan Beulich
2007-06-20 15:53     ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C29F0340.10F41%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.