From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Re: A wrong assert in get_ioreq()? Date: Wed, 04 Jul 2007 14:22:23 +0100 Message-ID: References: <34cec8c90707040412s4aa16fcdlbdd252e42a05f76e@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0969064117==" Return-path: In-Reply-To: <34cec8c90707040412s4aa16fcdlbdd252e42a05f76e@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paul Samon , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --===============0969064117== Content-type: multipart/alternative; boundary="B_3266403743_3027436" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3266403743_3027436 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit The lock is taken in, for example, hvm_vcpu_initialise(), which calles get_ioreq(v) with v!=current. So the assertion is correct as-is. -- Keir On 4/7/07 12:12, "Paul Samon" wrote: > Sorry, I meant the assert should "ASSERT(v == current)." > > On 7/4/07, Paul Samon wrote: >> I don't think it should be >> ASSERT(v == current). >> we don't get the lock first, and I think we needn't it. >> >> Am I missing something? >> >> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel --B_3266403743_3027436 Content-type: text/html; charset="US-ASCII" Content-transfer-encoding: quoted-printable Re: [Xen-devel] Re: A wrong assert in get_ioreq()? The l= ock is taken in, for example, hvm_vcpu_initialise(), which calles get_ioreq(= v) with v!=3Dcurrent. So the assertion is correct as-is.

 -- Keir

On 4/7/07 12:12, "Paul Samon" <paul.samon@gmail.com> wrote:=

Sorry, I meant the assert should "ASSERT(v =3D=3D curr= ent)."
 
On 7/4/07, Paul Samon <paul.samon@gmail.com> wrote:
I don't think it should be
    ASSERT(v =3D=3D current).
we don't get the lock first, and I think we needn't it.
 
Am I missing something?
 


____________________= ___________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/x= en-devel

 --B_3266403743_3027436-- --===============0969064117== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0969064117==--