From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: Re: [Xen-changelog] [linux-2.6.18-xen] Add
	"#ifdef ARCH_HAS_DEV_MEM" to archtecture specific file_operations.
Date: Mon, 09 Jul 2007 20:26:36 +0100
Message-ID: <C2B84A7C.A8F1%keir@xensource.com>
References: <1184008821.26508.56.camel@basalt>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1184008821.26508.56.camel@basalt>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: Jun Kamada <kama@jp.fujitsu.com>, xen-devel@lists.xensource.com, xen-ppc-devel <xen-ppc-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 9/7/07 20:20, "Hollis Blanchard" <hollisb@us.ibm.com> wrote:

>> By the way, I wonder how PPC manages to build both drivers/char/mem.c and
>> drivers/xen/char/mem.c without ARCH_HAS_DEV_MEM? The model is supposed to be
>> that mem_fops defined by the Xen file is picked up by the generic file. If
>> !ARCH_HAS_DEV_MEM then that doesn't happen -- so who picks up the Xen
>> mem_fops? 
> 
> Hmmm, yeah. Looks like we haven't tested that... :)

If you don't need to build both then there is potentially no problem with
the Xen file hijacking the xlate_dev_mem() functions.

 -- Keir