From: Keir Fraser <keir@xensource.com>
To: Lukas Hejtmanek <xhejtman@ics.muni.cz>
Cc: xen-devel@lists.xensource.com
Subject: Re: Permissive devices in Xen
Date: Tue, 10 Jul 2007 09:31:30 +0100 [thread overview]
Message-ID: <C2B90272.122A1%keir@xensource.com> (raw)
In-Reply-To: <20070709231425.GZ3885@ics.muni.cz>
On 10/7/07 00:14, "Lukas Hejtmanek" <xhejtman@ics.muni.cz> wrote:
> On Sun, Jul 08, 2007 at 11:10:12AM +0100, Keir Fraser wrote:
>> This was tracked down by Alex Williamson some time ago. There is code in
>> drivers/xen/pciback/conf_space_capability_pm.c:pm_ctrl_write() to restore
>> bars after a D3->D0 transition. I guess either your kernel does not have
>> that fix, or the fix needs to be extended slightly to cover whatever case
>> you are seeing.
>
> Would you be happy with patch like this?
Possibly, although I'm intrigued why the existing code to auto-reset the
BARs, in pm_ctrl_write(), doesn't work for you? Perhaps you could add some
tracing and find out? There might be a shorter patch that could be applied
there to get the existing code path working for you.
On the other hand, I don't really have anything against the patch you
submitted. If you have no joy with pm_ctrl_write() you can properly submit
your patch with a Signed-off-by line, and I'll apply it.
-- Keir
next prev parent reply other threads:[~2007-07-10 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 1:05 Permissive devices in Xen Lukas Hejtmanek
2007-07-08 9:55 ` Keir Fraser
2007-07-08 10:00 ` Lukas Hejtmanek
2007-07-08 10:10 ` Keir Fraser
2007-07-09 23:14 ` Lukas Hejtmanek
2007-07-10 8:31 ` Keir Fraser [this message]
2007-07-10 8:57 ` Lukas Hejtmanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2B90272.122A1%keir@xensource.com \
--to=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
--cc=xhejtman@ics.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.