From: Keir Fraser <keir@xensource.com>
To: Jun Kamada <kama@jp.fujitsu.com>
Cc: xen-devel@lists.xensource.com, Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdef ARCH_HAS_DEV_MEM" to archtecture specific file_operations.
Date: Wed, 11 Jul 2007 11:00:37 +0100 [thread overview]
Message-ID: <C2BA68D5.12413%keir@xensource.com> (raw)
In-Reply-To: <20070711143610.7F6E.KAMA@jp.fujitsu.com>
On 11/7/07 06:44, "Jun Kamada" <kama@jp.fujitsu.com> wrote:
>> We define it in asm/mach-xen/asm/io.h.
>>
>> However, the patch *is* of questionable value. It guards the only non-static
>> definition in the file with #ifdef ARCH_HAS_DEV_MEM. Which begs the question
>> why you would build the file at all if !ARCH_HAS_DEV_MEM. I'll revert it.
>
> I'm sorry that I had posted the incomplete patch. I will attach a new
> one modified. The patch resolves ploblems mentioned above?
The case of building drivers/xen/char/mem.c, yet not defining
ARCH_HAS_DEV_MEM, does not seem useful. Who will pick up and use the
mem_fops defined by drivers/xen/char/mem.c?
At the very least this seems abusive of ARCH_HAS_DEV_MEM, and you might be
better off defining a different macro name? But I think you need to explain
to us what it is you're actually trying to achieve.
-- Keir
next prev parent reply other threads:[~2007-07-11 10:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200707061715.l66HF2Ns030133@xenbits.xensource.com>
2007-07-06 20:25 ` [Xen-changelog] [linux-2.6.18-xen] Add "#ifdef ARCH_HAS_DEV_MEM" to archtecture specific file_operations Hollis Blanchard
2007-07-07 9:01 ` Keir Fraser
2007-07-09 19:20 ` Hollis Blanchard
2007-07-09 19:26 ` Keir Fraser
2007-07-09 19:41 ` Hollis Blanchard
2007-07-09 20:23 ` [XenPPC] " Jimi Xenidis
2007-07-09 21:20 ` Jimi Xenidis
2007-07-11 5:44 ` Jun Kamada
2007-07-11 10:00 ` Keir Fraser [this message]
2007-07-12 11:05 ` Jun Kamada
2007-07-13 2:42 ` [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdefARCH_HAS_DEV_MEM" " Akio Takebe
2007-07-13 12:54 ` Keir Fraser
2007-07-13 14:54 ` Isaku Yamahata
2007-07-13 15:09 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2BA68D5.12413%keir@xensource.com \
--to=keir@xensource.com \
--cc=hollisb@us.ibm.com \
--cc=kama@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.