From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH][SVM] HVM fix for SWINT event injection Date: Fri, 27 Jul 2007 16:57:15 +0100 Message-ID: References: <683860AD674C7348A0BF0DE3918482F605801851@SAUSEXMB1.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <683860AD674C7348A0BF0DE3918482F605801851@SAUSEXMB1.amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Woller, Thomas" , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 27/7/07 16:31, "Woller, Thomas" wrote: > Please apply to xen-unstable. > Applies cleanly to c/s 15651. > Signed-off-by Tom Woller The right thing to do here is copy the exitintinfo->eventinj only if eventinj.fields.v==0. And to add a comment that in future the two events should be 'merged' in the architecturally correct manner (e.g., turned into #DF in some cases). At least I *think* this is the right thing to do -- but now I think about it, is it actually ever okay to copy a SWINT from exitintinfo into eventinj? At the time the #PF vmexit happens, will EIP have been incremented across the SWINT instruction? If not, does eventinj of a SWINT correctly cause EIP to be incremented? > Note that HVM guests will not boot on AMD-V with xen-staging.hg c/s > 15652. > Keir, do you want me to take a look at staging c/s 15652 on AMD-V w/ > HVM? Yes please! Thanks, Keir