From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: compile error of HVM pv drivers Date: Mon, 30 Jul 2007 16:05:23 +0100 Message-ID: References: <10EA09EFD8728347A513008B6B0DA77AA3EF7B@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77AA3EF7B@pdsmsx411.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Zhao, Yunfeng" , Kieran Mansley Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org I think you'll find that doesn't fix the problem. The () is there for a reason. K. On 30/7/07 16:02, "Zhao, Yunfeng" wrote: > The problem may be from the new changes in > unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h > > the following two lines: > #define netif_tx_lock_bh(dev) (spin_lock_bh(&(dev)->xmit_lock)) > #define netif_tx_unlock_bh(dev) (spin_unlock_bh(&(dev)->xmit_lock)) > should be > #define netif_tx_lock_bh(dev) (spin_lock_bh(&dev->xmit_lock)) > #define netif_tx_unlock_bh(dev) (spin_unlock_bh(&dev->xmit_lock)) > "()" is useless for dev. > > Thanks > Yunfeng > > > >> -----Original Message----- >> From: Keir Fraser [mailto:keir@xensource.com] >> Sent: 2007年7月30日 22:52 >> To: Kieran Mansley; Zhao, Yunfeng >> Cc: xen-devel@lists.xensource.com >> Subject: Re: [Xen-devel] compile error of HVM pv drivers >> >> On 30/7/07 15:47, "Kieran Mansley" wrote: >> >>> In that case replacing the calls (there are two in that file) to >>> netif_tx_lock_bh() with: >>> >>> spin_lock_bh(&vif_state->np->netdev->xmit_lock); >>> >>> And similarly the calls to netif_tx_unlock_bh() with spin_unlock_bh(), >>> may solve your problem. >>> >>> If this works for you I'll make a patch that uses the kernel version to >>> decide which is appropriate. >> >> Compat issues when building PV-on-HVM drivers are patched up out-of-band in >> the special >> unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h >> header file. >> >> -- Keir > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel