From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Fix xenmon/xentrace compile on Solaris Date: Tue, 07 Aug 2007 14:48:38 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: john.levon@sun.com, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org That's a lot of code to include verbatim in our repository, especially for two non-essential build targets. There are two potential better alternatives: 1. Don't use argp at all in xentrace/xenmon -- do they really need super-advanced argument parsing such that getopt will not suffice? As low-level not-usually-user-visible daemons I would say that porting them to getopt would be acceptable even if the command-line option syntax needs changing a little to cleanly do so. 2. Is libargp available separately from libc? If so you could require users to install it if they wish to build xentrace/xenmon. Or you could maintain the libargp you posted out-of-tree. -- Keir On 7/8/07 14:14, "john.levon@sun.com" wrote: > # HG changeset patch > # User john.levon@sun.com > # Date 1186492378 25200 > # Node ID ae465d2d2b2ec9ab31598511fb35814ba6ab5602 > # Parent 1ddb3b21f4d8a6b449580ae45cf707f4b43198f9 > Fix xenmon/xentrace compile on Solaris > > The argp interface is only present in GNU libc. Include a local copy when > compiling on Solaris, and fix a couple of a trivial compile problems. > > Signed-off-by: Tariq Magdon-Ismail