From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Fix 64-bit foreign header check Date: Wed, 15 Aug 2007 17:04:30 +0100 Message-ID: References: <20070815152705.GA9299@barman.uk.sun.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070815152705.GA9299@barman.uk.sun.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 15/8/07 16:27, "John Levon" wrote: > There is no such "32-bit" environment, we can always produce both. What > you're > suggesting sounds like a cross-compile. This is absolutely not a cross > compile; > in particular we can and do want this header check to happen. > > We set XEN_COMPILE_ARCH by hand to 64-bit since the Xen makefiles have the > notion > that uname has anything to do with 32 or 64 bitness (a Linux-ism; in fact an > x86_64-Linux-ism, since I believe other Linux arches do it the traditional > way). Hmmm... Well varying COMPILE_ARCH when the compile arch is not actually changing seems dodgy to me. In any case, binaries that run on the compile host should build with HOSTCC/HOSTCFLAGS. That seems a pretty simple and obvious rule that I do not want to introduce exceptions to. -- Keir