From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] Fix 64-bit foreign header check
Date: Thu, 16 Aug 2007 08:15:45 +0100
Message-ID: <C2E9B831.CAB6%keir@xensource.com>
References: <20070815160823.GA10743@barman.uk.sun.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20070815160823.GA10743@barman.uk.sun.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: John Levon <john.levon@sun.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 15/8/07 17:08, "John Levon" <john.levon@sun.com> wrote:

>> Hmmm... Well varying COMPILE_ARCH when the compile arch is not actually
>> changing seems dodgy to me.
>> 
>> In any case, binaries that run on the compile host should build with
>> HOSTCC/HOSTCFLAGS. That seems a pretty simple and obvious rule that I do not
>> want to introduce exceptions to.
> 
> Can you please explain what you want us to do.

When you modify COMPILE_ARCH to x86_64, you should also modify HOSTCFLAGS to
include -m64. We can set HOSTCC/HOSTCFLAGS with '?=' assignment for this
purpose, in Config.mk. Or, perhaps better, you can set both COMPILE_ARCH and
HOSTCC/HOSTCFLAGS as you like in config/SunOS.mk based on XEN_TARGET_ARCH,
if that's always the sane thing to do on Solaris.

 -- Keir