From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] new hvm platform vhpet enable parameter Date: Thu, 14 Feb 2008 21:50:40 +0000 Message-ID: References: <20080214124819656.00000001516@djm-pc> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080214124819656.00000001516@djm-pc> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "dan.magenheimer@oracle.com" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 14/2/08 19:48, "Dan Magenheimer" wrote: >> It enables it by default if the tools do not explicitly >> instruct either way.... for old saved guest images... > > OK, I see. I'm glad you caught that. > > But does that mean if a guest config file does not explicitly > have a "hpet = 0" line, the default will be on? If so, > that's different from how I intended. Perhaps the > code in XendDomainInfo _constructDomain should be modified > to set it to zero if "hpet is None"? Else, I'll bet > guests created by virt-install will end up with hpet on. Yes, that's possible. Possibly XendConfig.py should set a default. Or virt-install itself should do so. > Also it occurs to me it might be a good idea to add a > gdprintk in hvm.c so that whether the hpet is on or not > is visibly logged. There are many config options for an HVM guest, none of which are logged by Xen. It would be inconsistent to log just this one. -- Keir