From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] tools: Check presence of ncurses
Date: Tue, 04 Mar 2008 11:24:46 +0000
Message-ID: <C3F2E1FE.1D6FE%keir.fraser@eu.citrix.com>
References: <20080304110725.GA5038@implementation.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080304110725.GA5038@implementation.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Samuel Thibault <samuel.thibault@eu.citrix.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Will this break cross-compile environments? Xentop is not built in that case
(hence no dependency on curses.h), yet your new check will still be
enforced. If it is the xentop usage that you are wanting to protect with a
check, perhaps the compile-or-not decision in xenstat/Makefile should be
made dynamically based on presence of curses.h?

 -- Keir

On 4/3/08 11:07, "Samuel Thibault" <samuel.thibault@eu.citrix.com> wrote:

> Add a check for the presence of ncurses development files
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
> 
> diff -r b28ae5f00553 tools/check/check_curses_devel
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/tools/check/check_curses_devel Tue Mar 04 11:06:06 2008 +0000
> @@ -0,0 +1,14 @@
> +#!/bin/sh
> +# CHECK-BUILD
> +
> +RC=0
> +
> +set -e
> +test -r /usr/include/curses.h || RC=1
> +
> +if test ${RC} -ne 0; then
> + echo
> + echo " *** Check for curses headers FAILED"
> +fi 
> +
> +exit ${RC}
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel