From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: Illegal PV kernel pfm/pfn translations on PROT_NONE ioremaps
Date: Thu, 20 Mar 2008 11:39:26 +0000 [thread overview]
Message-ID: <C407FD6E.1E29B%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <C407115D.1E26E%keir.fraser@eu.citrix.com>
On 19/3/08 18:52, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:
>> Yep. There are a number of bits that could be used: for example, I
>> don't think PROT_WRITE is ever going to be set on a PROT_NONE page,
>> either.
>
> My point is the flag would be set even when the protection is not PROT_NONE.
> It has other uses beyond fixing this bug.
>
> I might look into doing this myself as I think it is probably the best fix for
> this issue.
...and the issue is now fixed (changeset 488) in
http://xenbits.xensource.com/staging/linux-2.6.18-xen.hg
The patch is a minimal one given the approach of using a new _PAGE_IO flag.
For example, pte_pfn() probably no longer needs to use mfn_to_local_pfn()
and could use the simpler and faster mfn_to_pfn() instead. But that belongs
in a separate patch.
-- Keir
next prev parent reply other threads:[~2008-03-20 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 15:39 Illegal PV kernel pfm/pfn translations on PROT_NONE ioremaps Stephen C. Tweedie
2008-03-19 16:00 ` Keir Fraser
2008-03-19 16:31 ` Stephen C. Tweedie
2008-03-19 16:42 ` Keir Fraser
2008-03-19 17:12 ` Stephen C. Tweedie
2008-03-19 18:52 ` Keir Fraser
2008-03-20 11:39 ` Keir Fraser [this message]
2008-03-28 16:41 ` Stephen C. Tweedie
2008-03-28 16:44 ` Keir Fraser
2008-03-28 16:45 ` Keir Fraser
2008-03-19 16:34 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C407FD6E.1E29B%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=sct@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.