From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] unnamed union structure members are dangerous to expose in public headers Date: Tue, 25 Mar 2008 17:33:53 +0000 Message-ID: References: <20080325172534.GD6845@implementation.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080325172534.GD6845@implementation.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Samuel Thibault , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 25/3/08 17:25, "Samuel Thibault" wrote: > will return 0x13e0 when compiled without gcc -std=c99, while the > expected value is 0x1430, resulting to seg faults and all kinds of > tricks. Compiling with > > #include "/usr/include/xen/foreign/x86_64.h" > > shows why: > > /usr/include/xen/foreign/x86_64.h:88: warning: declaration does not > declare anything This raises two obvious questions: 1. Why building with -std=c99? 2. Why building without -Werror? -- Keir