From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Re: [Xen-staging] [xen-unstable] Explicitly
 tag every anonymous aggregate in the public headers.
Date: Mon, 31 Mar 2008 17:21:48 +0100
Message-ID: <C416CE2C.1EA53%keir.fraser@eu.citrix.com>
References: <1206978571.7735.10.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1206978571.7735.10.camel@lappy>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Alex Williamson <alex.williamson@hp.com>
Cc: xen-ia64-devel <xen-ia64-devel@lists.xensource.com>, xen-devel <xen-devel@lists.xensource.com>, Samuel Thibault <samuel.thibault@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 31/3/08 16:49, "Alex Williamson" <alex.williamson@hp.com> wrote:

> It seems pretty clear that in nesting __extension__ attributes in this
> manner, the struct is actually ignored and the compiler is treating the
> everything that was in the struct as a separate member of the union.  In
> the mapped_regs example, the structure size remains correct only because
> the union is full padded out using the full size arrays.  Please apply
> the patch I sent previously to revert the nested __extension__
> attributes.  Thanks,

__extension__ seems worryingly half-baked. We're better off asserting
!__STRICT_ANSI__ in my opinion. I don't suppose you much care either way as
long as ia64 boot works again. :-)

 -- Keir