From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXen Date: Fri, 11 Apr 2008 13:14:10 +0100 Message-ID: References: <47FF70CA.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47FF70CA.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Haitao Shan Cc: Weidong Han , Kevin Tian , Yunhong Jiang , Allen M Kay , xen-devel List-Id: xen-devel@lists.xenproject.org On 11/4/08 13:08, "Jan Beulich" wrote: > I don't think this is going to do what you want when the kernel is using > mmconfig, or AMD's extended register space access method (not to > speak of the hopefully not in wide spread use type 2 access method). The aim is to synchronise accesses to the PCI window registers cf8/cfc. It's not to synchronise the PCI config space accesses themselves. > Also I find it a little odd that you allow access to ports cf9...cfb rather > than properly handling namely byte accesses to cf9. Likewise it > doesn't consider the (albeit unlikely) case of multi-byte accesses to > ports crossing the cf8/cfc boundary. I've cleaned this up and basically rewritten the patch. I'll be checking it in this afternoon. -- Keir