From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: long latency of domain shutdown
Date: Thu, 08 May 2008 13:11:21 +0100 [thread overview]
Message-ID: <C448AC79.2072B%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4822FC70.76E4.0078.0@novell.com>
On 8/5/08 12:13, "Jan Beulich" <jbeulich@novell.com> wrote:
>> Nor am I convinced about how much potential time-saving
>> there is to be had here.
>
> I'm not seeing any time saving here. The other thing I brought up
> was just an unrelated item pointing out potential for code
> simplification.
Ah, yes, I see.
The approach looks plausible. I think in its current form it will leave
zombie L2/L3 pages hanging around and the domain will never actually
properly die (e.g., still will be visible with the 'q' key). Because
although you do get around to doing free_lX_table(), the type count and ref
count of the L2/L3 pages will not drop to zero because the dead L3/L4 page
never actually dropped its references properly.
In actuality, since we know that we never have 'cross-domain' pagetable type
references, we should actually be able to zap pagetable reference counts to
zero. The only reason we don't do that right now is really because it
provides good debugging info to see whether a domain's refcounts have got
screwed up. But that would not prevent us doing something faster for NDEBUG
builds, at least.
Does that make sense?
-- Keir
next prev parent reply other threads:[~2008-05-08 12:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48189781.76E4.0078.0@novell.com>
[not found] ` <C43E4040.2022A%keir.fraser@eu.citrix.com>
2008-05-08 9:58 ` long latency of domain shutdown Jan Beulich
2008-05-08 10:12 ` Keir Fraser
2008-05-08 10:39 ` Jan Beulich
2008-05-08 10:52 ` Keir Fraser
2008-05-08 11:13 ` Jan Beulich
2008-05-08 12:11 ` Keir Fraser [this message]
2008-05-08 12:33 ` Jan Beulich
2008-05-08 12:36 ` Keir Fraser
2008-05-08 14:29 ` Jan Beulich
2008-05-08 14:38 ` Keir Fraser
2008-05-09 10:23 ` Jan Beulich
2008-05-09 10:29 ` Keir Fraser
2008-04-28 13:45 Jan Beulich
2008-04-28 13:59 ` Keir Fraser
2008-04-28 14:30 ` Jan Beulich
2008-04-28 14:42 ` Keir Fraser
2008-05-14 15:54 ` Jan Beulich
2008-05-14 16:05 ` Jan Beulich
2008-05-14 16:08 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C448AC79.2072B%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.