From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 0/4] HVM Virtual S3 Date: Wed, 14 May 2008 13:17:20 +0100 Message-ID: References: <391BF3CDD2DC0848B40ACB72FA97AD59035AABF4@pdsmsx413.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <391BF3CDD2DC0848B40ACB72FA97AD59035AABF4@pdsmsx413.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Ke, Liping" , Ian Pratt , "Yu, Ke" , xen-devel@lists.xensource.com Cc: "Tian, Kevin" , "Jiang, Yunhong" List-Id: xen-devel@lists.xenproject.org On 14/5/08 10:50, "Ke, Liping" wrote: > 1. if hvm in s3suspended, could we allow pause/unpause/suspend/resume > operation? > Need we add condition guard in python code? I think pause/unpause still makes sense. Obviously a paused and s3suspended guest will not run again until both s3 resumed and unpaused. As for suspend/resume, that should also just work I think? Isn't the point to be able to s3-suspend then save then restore then s3-resume? > 2. when we add a new flag is_s3_suspended in dominfo structure, it will affect > other > Trace/statistic tools in xen, seems this is not a very small change? > The above two changes is ok for you or not? I don't really care to have is_s3_suspended visible via dominfo. Leave it hidden if you like. Xend should be able to remember whether it s3-suspended a domain, if it needs to. Or we can expose it via an interface other than dominfo. We could, for example, make it an HVM_PARAM. Then you can enter/leave/interrogate s3suspend state via the existing hvm_op param interfaces. -- Keir