From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Erickson Date: Wed, 11 Jun 2008 16:10:18 -0700 Subject: [U-Boot-Users] [PATCH] Add PPC405 External Bus Controller (EBC) Register Field Mnemonics In-Reply-To: <20080611230048.A152324345@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 6/11/08 4:00 PM, Wolfgang Denk wrote: > In message <1210886606-12929-1-git-send-email-gerickson@nuovations.com> you > wrote: >> Added preprocessor definitions for External Bus Controller (EBC) >> configuration, bank configuration and access parameter register fields >> along with a macro for defining them and verifying them against the >> data sheet or user's manual easier. >> >> Tested against AMCC "Haleakala". >> >> Signed-off-by: Grant Erickson > > Are these definitions being used anywhere? > > I tend to drop this patch because it seems to be just dead code. > Stefan, do you agree? > > > Best regards, > > Wolfgang Denk Wolfgang, These are actually now used in cpu/ppc4xx/start.S and are probably already included in the latest 4xx pull from Stefan. So, this patch might be a no-op at this point. Regardless, while they are not used in include/configs/kilauea.h and include/configs/makalu.h yet (but both could and should be) I have used them in the include/config/.h for the new boards I am supporting for a client. They make it much easier to decode BxAP and BxCR settings than an arbitrary 32-bit hex value. Regards, Grant