From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>, Gang Wei <gang.wei@intel.com>,
xen-devel@lists.xensource.com
Cc: Ke Yu <ke.yu@intel.com>
Subject: Re: please revert c/s 17686
Date: Fri, 13 Jun 2008 09:24:44 +0100 [thread overview]
Message-ID: <C477ED5C.19C30%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <48524817.76E4.0078.0@novell.com>
On 13/6/08 09:12, "Jan Beulich" <jbeulich@novell.com> wrote:
>>> I missed that warning printk. It does indeed look odd.
>>
>> As to this warning printk, we can simply replace it with an assert.
>
> That would make things worse, not better - the condition simply must be
> allowed (as said before, otherwise you won't be able to bring all CPUs
> at once into C3).
I think that C2/C3 are entered with IRQs disabled, but IRQ pending will kick
the CPU out of C2/C3 nonetheless. That CPU will then execute
hpet_broadcast_exit() before local_irq_enable() and hence the warning printk
will never actually fire. So it would be correct as a BUG_ON().
Is this correct, Wei?
-- Keir
next prev parent reply other threads:[~2008-06-13 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 13:28 please revert c/s 17686 Jan Beulich
2008-06-12 13:56 ` Keir Fraser
2008-06-12 14:01 ` Jan Beulich
2008-06-12 16:22 ` Keir Fraser
2008-06-13 2:08 ` Wei, Gang
2008-06-13 7:31 ` Keir Fraser
2008-06-13 7:45 ` Jan Beulich
2008-06-13 7:51 ` Keir Fraser
2008-06-13 8:06 ` Wei, Gang
2008-06-13 8:12 ` Jan Beulich
2008-06-13 8:24 ` Keir Fraser [this message]
2008-06-13 13:12 ` Wei, Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C477ED5C.19C30%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=gang.wei@intel.com \
--cc=jbeulich@novell.com \
--cc=ke.yu@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.