All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Chris Lalancette <clalance@redhat.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH]: Fix syscall return code when ptrace or audit is active
Date: Mon, 30 Jun 2008 16:12:33 +0100	[thread overview]
Message-ID: <C48EB671.234D1%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4868E8FA.4040701@redhat.com>

On 30/6/08 15:08, "Chris Lalancette" <clalance@redhat.com> wrote:

> Attached is a simple patch to fix the return value from the 64-bit kernel when
> you call with a bad system call number with tracing enabled (for either ptrace
> or audit).  What should happen is that the user process gets a -ENOSYS return
> call from the syscall; what actually happens (only in the 64-bit kernel) is
> that
> you get back the system call number.  The 32-bit kernel does not suffer from
> this bug, and the pv-ops implementation in the upstream Linux kernel also does
> not have this bug.  The attached patch makes the tracesys path look the same
> as
> it does in upstream Linux, and ensures that we return -ENOSYS on this path.

Thanks. The removal of 'jmp int_ret_from_sys_call' is not part of the
bugfix, and also I think the code is clearer if we keep it. So I've applied
all of this patch except the removal of that jmp.

 -- Keir

  reply	other threads:[~2008-06-30 15:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 14:08 [PATCH]: Fix syscall return code when ptrace or audit is active Chris Lalancette
2008-06-30 15:12 ` Keir Fraser [this message]
2008-06-30 15:20   ` Chris Lalancette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C48EB671.234D1%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=clalance@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.