From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: ioemu build failure with GCC > 4.3
Date: Thu, 10 Jul 2008 10:39:31 +0100
Message-ID: <C49B9763.23DA8%keir.fraser@eu.citrix.com>
References: <37E52D09333DE2469A03574C88DBF40F021BEF97@pdsmsx414.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <37E52D09333DE2469A03574C88DBF40F021BEF97@pdsmsx414.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "He, Qing" <qing.he@intel.com>, ian.jackson@eu.citrix.com
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 10/7/08 10:32, "He, Qing" <qing.he@intel.com> wrote:

> It's most straightforward to remove `inline' in slirp/misc.c, the code
> doesn't really seem to benefit from it. But it looks pretty old and not
> maintained for sometime. What about patch it locally?
> 
> Other options include specify `-fgnu89-inline' (n/a prior to GCC 4.1.3)
> and overrides slirp compile line with `-std=gnu89', but may not be
> preferred.

Could we change the '#define inline' in slirp_config.h to define it to
nothing? None of the usages of 'inline' in the slirp directory look like a
particularly good idea.

 -- Keir