From: Michael Hernandez <michael.hernandez@qlogic.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3 of 6] scsi: Support devices with protection information
Date: Thu, 17 Jul 2008 13:42:58 -0700 [thread overview]
Message-ID: <C4A4FCE2.2CCA%michael.hernandez@qlogic.com> (raw)
In-Reply-To: <9b588aeb5c5b9b618fca.1216283312@sermon.lab.mkp.net>
On 7/17/08 1:28 AM, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:
> diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
> --- a/drivers/scsi/scsi.c
> +++ b/drivers/scsi/scsi.c
> @@ -199,24 +199,60 @@ scsi_pool_free_command(struct scsi_host_
> {
> kmem_cache_free(pool->sense_slab, cmd->sense_buffer);
> kmem_cache_free(pool->cmd_slab, cmd);
> +
> + if (cmd->prot_sdb)
> + kmem_cache_free(scsi_sdb_cache, cmd->prot_sdb);
> +}
> +
Shouldn't this check (and potential kmem_cache_free call) get done before
freeing the cmd to the cmd_slab?
Mike
next prev parent reply other threads:[~2008-07-17 20:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 8:28 [PATCH 0 of 6] SCSI Data Integrity Support Martin K. Petersen
2008-07-17 8:28 ` [PATCH 1 of 6] scsi: Host protection capabilities Martin K. Petersen
2008-07-17 8:28 ` [PATCH 2 of 6] scsi: Command protection operation Martin K. Petersen
2008-07-17 8:28 ` [PATCH 3 of 6] scsi: Support devices with protection information Martin K. Petersen
2008-07-17 17:53 ` James Bottomley
2008-07-17 18:39 ` Martin K. Petersen
2008-07-17 20:42 ` Michael Hernandez [this message]
2008-07-17 21:08 ` Martin K. Petersen
2008-07-17 8:28 ` [PATCH 4 of 6] scsi: Do not retry a request whose data integrity check failed Martin K. Petersen
2008-07-17 8:28 ` [PATCH 5 of 6] sd: Identify DIF protection type and application tag ownership Martin K. Petersen
2008-07-17 8:28 ` [PATCH 6 of 6] sd: Support for SCSI disk (SBC) Data Integrity Field Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2008-07-10 2:48 [PATCH 0 of 6] SCSI Data Integrity Support Martin K. Petersen
2008-07-10 2:48 ` [PATCH 3 of 6] scsi: Support devices with protection information Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4A4FCE2.2CCA%michael.hernandez@qlogic.com \
--to=michael.hernandez@qlogic.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.