From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Pat Campbell <plc@novell.com>
Subject: Re: build problem with new ioemu
Date: Fri, 18 Jul 2008 14:08:22 +0100 [thread overview]
Message-ID: <C4A65456.24490%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <200807181459.24305.Christoph.Egger@amd.com>
On 18/7/08 13:59, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>> Old code did:
>> /* Some versions of usbdevice_fs.h need __user to be defined for them. */
>> /* This may (harmlessly) conflict with a definition in linux/compiler.h. */
>> #define __user
>> #include <linux/usbdevice_fs.h>
>>
>> Not sure which is the better solution
>>
>> Pat
>
> This patch works. Tnx.
>
> Keir: Please apply it.
IanJ is on it.
The old approach is better than linux/compiler.h since not all systems have
that header (and if they do, may not define __user).
-- Keir
next prev parent reply other threads:[~2008-07-18 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 12:10 build problem with new ioemu Christoph Egger
2008-07-18 13:00 ` Pat Campbell
2008-07-18 12:59 ` Christoph Egger
2008-07-18 13:08 ` Keir Fraser [this message]
2008-07-18 13:13 ` Christoph Egger
2008-07-18 13:15 ` Keir Fraser
2008-07-18 14:47 ` Ian Jackson
2008-07-18 14:52 ` Ian Jackson
2008-07-18 14:44 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4A65456.24490%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=plc@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.